Commit graph

412 commits

Author SHA1 Message Date
Alexander Vasilyev
12396125e7 Add tests for correct coverage calculations. 2020-03-27 22:32:10 +03:00
Alexander Vasilyev
a56f50ac46 Calculate coverage of private code.
Create empty coverage profile from problem code to calculate coverage
correctly. For some wierd reasons it will also account for not tested packages.
This change prevents students from adding new code and testing it,
instead of getting good coverage for initial codebase :)
2020-03-27 22:32:10 +03:00
Alexander Vasilyev
54ab7b69d1 Add coverpkg specification.
Currently, packages in coverme without tests created by student
are not checked for coverage, because no there are no test targets
for them at all!

The issue can be fixed by simply creating empty !change files,
but we are engineers, aren't we? :)

Bonus point: it prevents new packages from giving false coverage credit.
For example, mock file generated by gomock will have lots of covered code
almost instantly. However, the task can be hacked by adding new code to
existing packages.
2020-03-27 22:32:10 +03:00
Alexander Vasilyev
f81398290b Remove ignored min coverage comments. 2020-03-27 22:32:10 +03:00
Alexander Vasilyev
545ce5cbe3 Calculate coverage problem-wise, not per package.
This seems to be fair, especially since coverage target is
defined problem-wise. Practical reason: coverme/app can not
be covered sufficiently without testing Start/initRoutes/run;
out of these, only initRoutes can be tested, and testing it
separately is a wierd solution.
2020-03-27 22:32:10 +03:00
Arseny Balobanov
4847cc86c8 batcher: try fixing submissions by adding empty source file to slow subpkg. 2020-03-27 15:01:57 +03:00
Oleg Khlevnov
cee54236ab Update string case in TestEqual assertions_test.go 2020-03-27 12:00:00 +03:00
Arseny Balobanov
71ed3bdf3e coverme: fix spacing. 2020-03-27 02:12:22 +03:00
mfgnik
f2ba356a61 Update coverage_test.go 2020-03-27 02:10:53 +03:00
mfgnik
d17ba8106e Update coverage_test.go 2020-03-27 02:10:51 +03:00
mfgnik
5ad126327d Update coverage_test.go 2020-03-27 02:10:50 +03:00
mfgnik
3d88c79622 Add check for existence tests for all packages 2020-03-27 02:10:46 +03:00
Arseny Balobanov
f8821ccc59 testequal: fix readme. 2020-03-26 21:18:12 +03:00
Arseny Balobanov
c01578963d Releasing pubsub. 2020-03-26 20:50:16 +03:00
verytable
6ff59e81fc Merge branch 'pubsub' into 'master'
Add pubsub task

See merge request slon/shad-go-private!21
2020-03-26 17:42:29 +00:00
Andrew
2a4bb7f0b8 Add pubsub task 2020-03-26 17:42:29 +00:00
Arseny Balobanov
b2a9e833f8 Releasing new task group with single batcher task. 2020-03-26 20:36:15 +03:00
Fedor Korotkiy
22fc994458 Fix lecture 2020-03-26 17:57:49 +03:00
Fedor Korotkiy
29089ced33 Add shared memory lecture 2020-03-26 16:34:09 +03:00
Arseny Balobanov
4304387383 testequal: add tests that compare map with slice to forbid using short form of type assertion in solution 2020-03-25 23:09:19 +03:00
Arseny Balobanov
febc967100 testequal: check that AssertEqual == !AssertNotEqual. 2020-03-25 23:04:04 +03:00
Rak Alexey
bfb17611fe Swap actual and expected in require.Equal. 2020-03-23 22:25:07 +03:00
Arseny Balobanov
d025403144 testtool: fix build tag in submission test. 2020-03-23 22:21:42 +03:00
Arseny Balobanov
e2fbd87846 fix task name 2020-03-22 06:45:39 +03:00
Arseny Balobanov
fd90a734d3 Releasing testequal. 2020-03-22 06:42:18 +03:00
verytable
7e14d269e7 Merge branch '14-type-switch-task' into 'master'
Resolve "type switch task"

Closes #14

See merge request slon/shad-go-private!22
2020-03-22 03:39:15 +00:00
Arseny Balobanov
4423e722a9 Move error message tests from helper test to separate test. 2020-03-22 06:35:22 +03:00
Vetrov Alexey
7fb06f4ac4 Fix invalid URL in client 2020-03-22 04:17:41 +03:00
Vetrov Alexey
6c871e6474 Unfished -> Unfinished 2020-03-22 04:14:05 +03:00
Arseny Balobanov
2b49e0ea2f Rename require.go to assertions.go. 2020-03-21 03:52:43 +03:00
Arseny Balobanov
3fe2f3144f Fix string benchmark size; rename benchmarks; add map benchmark. 2020-03-21 03:50:02 +03:00
Arseny Balobanov
69abab266c Add note about err msg. 2020-03-21 03:32:54 +03:00
Arseny Balobanov
39c638aa2f Fix readme. 2020-03-21 03:12:06 +03:00
Arseny Balobanov
063b5e9764 Fix benchmark name. 2020-03-21 03:04:24 +03:00
Arseny Balobanov
fb1b643ca8 Adding testequal task. 2020-03-21 02:56:58 +03:00
Arseny Balobanov
5f1b033f10 testtool: fix cover profile permissions issue by writing profile to /tmp. 2020-03-20 13:00:17 +03:00
Arseny Balobanov
a74e207ea3 testtool: fix coverage comment search dir. 2020-03-20 11:59:20 +03:00
Arseny Balobanov
5379d8dbf7 tparallel: fix typos in readme. 2020-03-20 02:50:25 +03:00
Arseny Balobanov
5aa7ef083a coverme: add links to slides and testify. 2020-03-20 02:14:23 +03:00
Arseny Balobanov
c0abffe339 Releasing coverme. 2020-03-20 01:58:54 +03:00
Fedor Korotkiy
2fe00359e2 Update README.md 2020-03-19 22:56:52 +00:00
verytable
629e9b3c92 Merge branch '16-test-coverage' into 'master'
Resolve "test coverage"

Closes #16

See merge request slon/shad-go-private!20
2020-03-19 22:49:24 +00:00
Arseny Balobanov
ccd5e77396 coverme: add note about 100% coverage. 2020-03-20 01:38:59 +03:00
Arseny Balobanov
6d948ff9da Fix readme. 2020-03-20 01:30:21 +03:00
Arseny Balobanov
ad8e27c53a coverme: increase min coverage from 85% to 90% 2020-03-20 01:16:07 +03:00
Arseny Balobanov
fb5f9d5aad Fix imports. 2020-03-20 01:02:50 +03:00
Arseny Balobanov
235923eba8 Fix imports. 2020-03-20 01:00:46 +03:00
Arseny Balobanov
9ce2d57196 Adding todo-app coverage task. 2020-03-20 00:57:07 +03:00
Fedor Korotkiy
23d64d2a04 Fix 2020-03-19 21:53:01 +03:00
Arseny Balobanov
03a063f40e Releasing Testing task group with single tparallel task. 2020-03-19 21:06:26 +03:00