From 8eddf48fa9fe7ee8a5b78b75ea1b9d279e334e15 Mon Sep 17 00:00:00 2001 From: Fedor Korotkiy Date: Fri, 14 Feb 2020 15:55:10 +0300 Subject: [PATCH] Run linter on submit --- tools/testtool/commands/test_submission.go | 22 +++++- .../correct/sum/private/.golangci.yml | 77 +++++++++++++++++++ .../incorrect/brokenstyle/description.md | 1 + .../brokenstyle/private/.golangci.yml | 77 +++++++++++++++++++ .../brokenstyle/private/brokenstyle/sum.go | 7 ++ .../private/brokenstyle/sum_private_test.go | 45 +++++++++++ .../private/brokenstyle/sum_solution.go | 7 ++ .../private/brokenstyle/sum_test.go | 22 ++++++ .../private/brokenstyle/testdata/tests.csv | 3 + .../incorrect/brokenstyle/private/go.mod | 9 +++ .../incorrect/brokenstyle/private/go.sum | 53 +++++++++++++ .../brokenstyle/student/brokenstyle/sum.go | 8 ++ .../student/brokenstyle/sum_test.go | 23 ++++++ .../student/brokenstyle/testdata/tests.csv | 3 + .../incorrect/brokenstyle/student/go.mod | 9 +++ .../incorrect/brokenstyle/student/go.sum | 53 +++++++++++++ .../brokentest/private/.golangci.yml | 77 +++++++++++++++++++ .../newdependency/private/.golangci.yml | 77 +++++++++++++++++++ 18 files changed, 571 insertions(+), 2 deletions(-) create mode 100644 tools/testtool/testdata/submissions/correct/sum/private/.golangci.yml create mode 100644 tools/testtool/testdata/submissions/incorrect/brokenstyle/description.md create mode 100644 tools/testtool/testdata/submissions/incorrect/brokenstyle/private/.golangci.yml create mode 100644 tools/testtool/testdata/submissions/incorrect/brokenstyle/private/brokenstyle/sum.go create mode 100644 tools/testtool/testdata/submissions/incorrect/brokenstyle/private/brokenstyle/sum_private_test.go create mode 100644 tools/testtool/testdata/submissions/incorrect/brokenstyle/private/brokenstyle/sum_solution.go create mode 100644 tools/testtool/testdata/submissions/incorrect/brokenstyle/private/brokenstyle/sum_test.go create mode 100644 tools/testtool/testdata/submissions/incorrect/brokenstyle/private/brokenstyle/testdata/tests.csv create mode 100644 tools/testtool/testdata/submissions/incorrect/brokenstyle/private/go.mod create mode 100644 tools/testtool/testdata/submissions/incorrect/brokenstyle/private/go.sum create mode 100644 tools/testtool/testdata/submissions/incorrect/brokenstyle/student/brokenstyle/sum.go create mode 100644 tools/testtool/testdata/submissions/incorrect/brokenstyle/student/brokenstyle/sum_test.go create mode 100644 tools/testtool/testdata/submissions/incorrect/brokenstyle/student/brokenstyle/testdata/tests.csv create mode 100644 tools/testtool/testdata/submissions/incorrect/brokenstyle/student/go.mod create mode 100644 tools/testtool/testdata/submissions/incorrect/brokenstyle/student/go.sum create mode 100644 tools/testtool/testdata/submissions/incorrect/brokentest/private/.golangci.yml create mode 100644 tools/testtool/testdata/submissions/incorrect/newdependency/private/.golangci.yml diff --git a/tools/testtool/commands/test_submission.go b/tools/testtool/commands/test_submission.go index f3c1cab..a3e3488 100644 --- a/tools/testtool/commands/test_submission.go +++ b/tools/testtool/commands/test_submission.go @@ -121,8 +121,13 @@ func testSubmission(studentRepo, privateRepo, problem string) error { copyDir(privateRepo, path.Join(problem, testdataDir), tmpRepo) // Copy go.mod and go.sum from private repo to temp dir. - log.Printf("copying go.mod and go.sum") - copyFiles(privateRepo, []string{"go.mod", "go.sum"}, tmpRepo) + log.Printf("copying go.mod, go.sum and .golangci.yml") + copyFiles(privateRepo, []string{"go.mod", "go.sum", ".golangci.yml"}, tmpRepo) + + log.Printf("running linter") + if err := runLinter(tmpRepo, problem); err != nil { + return err + } // Run tests. log.Printf("running tests") @@ -185,6 +190,19 @@ func (e *TestFailedError) Unwrap() error { return e.E } +func runLinter(testDir, problem string) error { + cmd := exec.Command("golangci-lint", "run", "--modules-download-mode", "readonly", "--build-tags", "private", fmt.Sprintf("./%s/...", problem)) + cmd.Dir = testDir + cmd.Stdout = os.Stdout + cmd.Stderr = os.Stderr + + if err := cmd.Run(); err != nil { + return fmt.Errorf("linter failed: %w", err) + } + + return nil +} + // runTests runs all tests in directory with race detector. func runTests(testDir, problem string) error { binCache, err := ioutil.TempDir("/tmp", "bincache") diff --git a/tools/testtool/testdata/submissions/correct/sum/private/.golangci.yml b/tools/testtool/testdata/submissions/correct/sum/private/.golangci.yml new file mode 100644 index 0000000..4b4d4be --- /dev/null +++ b/tools/testtool/testdata/submissions/correct/sum/private/.golangci.yml @@ -0,0 +1,77 @@ +# options for analysis running +run: + # default concurrency is a available CPU number + concurrency: 8 + + # timeout for analysis, e.g. 30s, 5m, default is 1m + deadline: 5m + + # exit code when at least one issue was found, default is 1 + issues-exit-code: 1 + + # include test files or not, default is true + tests: true + + +# output configuration options +output: + # colored-line-number|line-number|json|tab|checkstyle, default is "colored-line-number" + format: colored-line-number + + # print lines of code with issue, default is true + print-issued-lines: true + + # print linter name in the end of issue text, default is true + print-linter-name: true + + +# all available settings of specific linters +linters-settings: + govet: + # report about shadowed variables + check-shadowing: true + golint: + # minimal confidence for issues, default is 0.8 + min-confidence: 0.8 + gofmt: + # simplify code: gofmt with `-s` option, true by default + simplify: true + goimports: + # put imports beginning with prefix after 3rd-party packages; + # it's a comma-separated list of prefixes + local-prefixes: gitlab.com + +linters: + disable-all: true + enable: + - errcheck + - gofmt + - golint + - gosimple + - govet + - ineffassign + - scopelint + - staticcheck + - typecheck + - unconvert + + +issues: + # List of regexps of issue texts to exclude, empty list by default. + # But independently from this option we use default exclude patterns, + # it can be disabled by `exclude-use-default: false`. To list all + # excluded by default patterns execute `golangci-lint run --help` + exclude: + - Using the variable on range scope .* in function literal + + # Independently from option `exclude` we use default exclude patterns, + # it can be disabled by this option. To list all + # excluded by default patterns execute `golangci-lint run --help`. + # Default value for this option is true. + exclude-use-default: true + + # Maximum issues count per one linter. Set to 0 to disable. Default is 50. + max-per-linter: 0 + + # Maximum count of issues with the same text. Set to 0 to disable. Default is 3. + max-same-issues: 0 diff --git a/tools/testtool/testdata/submissions/incorrect/brokenstyle/description.md b/tools/testtool/testdata/submissions/incorrect/brokenstyle/description.md new file mode 100644 index 0000000..77c9850 --- /dev/null +++ b/tools/testtool/testdata/submissions/incorrect/brokenstyle/description.md @@ -0,0 +1 @@ +Student solution compiles but does not pass tests. \ No newline at end of file diff --git a/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/.golangci.yml b/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/.golangci.yml new file mode 100644 index 0000000..4b4d4be --- /dev/null +++ b/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/.golangci.yml @@ -0,0 +1,77 @@ +# options for analysis running +run: + # default concurrency is a available CPU number + concurrency: 8 + + # timeout for analysis, e.g. 30s, 5m, default is 1m + deadline: 5m + + # exit code when at least one issue was found, default is 1 + issues-exit-code: 1 + + # include test files or not, default is true + tests: true + + +# output configuration options +output: + # colored-line-number|line-number|json|tab|checkstyle, default is "colored-line-number" + format: colored-line-number + + # print lines of code with issue, default is true + print-issued-lines: true + + # print linter name in the end of issue text, default is true + print-linter-name: true + + +# all available settings of specific linters +linters-settings: + govet: + # report about shadowed variables + check-shadowing: true + golint: + # minimal confidence for issues, default is 0.8 + min-confidence: 0.8 + gofmt: + # simplify code: gofmt with `-s` option, true by default + simplify: true + goimports: + # put imports beginning with prefix after 3rd-party packages; + # it's a comma-separated list of prefixes + local-prefixes: gitlab.com + +linters: + disable-all: true + enable: + - errcheck + - gofmt + - golint + - gosimple + - govet + - ineffassign + - scopelint + - staticcheck + - typecheck + - unconvert + + +issues: + # List of regexps of issue texts to exclude, empty list by default. + # But independently from this option we use default exclude patterns, + # it can be disabled by `exclude-use-default: false`. To list all + # excluded by default patterns execute `golangci-lint run --help` + exclude: + - Using the variable on range scope .* in function literal + + # Independently from option `exclude` we use default exclude patterns, + # it can be disabled by this option. To list all + # excluded by default patterns execute `golangci-lint run --help`. + # Default value for this option is true. + exclude-use-default: true + + # Maximum issues count per one linter. Set to 0 to disable. Default is 50. + max-per-linter: 0 + + # Maximum count of issues with the same text. Set to 0 to disable. Default is 3. + max-same-issues: 0 diff --git a/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/brokenstyle/sum.go b/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/brokenstyle/sum.go new file mode 100644 index 0000000..bb7b546 --- /dev/null +++ b/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/brokenstyle/sum.go @@ -0,0 +1,7 @@ +// +build !solution + +package brokenstyle + +func Sum(a, b int64) int64 { + return 0 +} diff --git a/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/brokenstyle/sum_private_test.go b/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/brokenstyle/sum_private_test.go new file mode 100644 index 0000000..d51f782 --- /dev/null +++ b/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/brokenstyle/sum_private_test.go @@ -0,0 +1,45 @@ +// +build private + +package brokenstyle + +import ( + "encoding/csv" + "os" + "strconv" + "testing" + + "github.com/stretchr/testify/require" +) + +// Read tests from csv file. +func readTestCases(filename string) ([]*testCase, error) { + f, err := os.Open(filename) + if err != nil { + return nil, err + } + + records, err := csv.NewReader(f).ReadAll() + if err != nil { + return nil, err + } + + var tests []*testCase + for _, r := range records { + a, _ := strconv.ParseInt(r[0], 10, 64) + b, _ := strconv.ParseInt(r[1], 10, 64) + sum, _ := strconv.ParseInt(r[2], 10, 64) + tests = append(tests, &testCase{a: a, b: b, sum: sum}) + } + + return tests, nil +} + +func TestSumPrivate(t *testing.T) { + tests, err := readTestCases("./testdata/tests.csv") + require.Nil(t, err) + + for _, tc := range tests { + s := Sum(tc.a, tc.b) + require.Equal(t, tc.sum, s, "%d + %d == %d != %d", tc.a, tc.b, s, tc.sum) + } +} diff --git a/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/brokenstyle/sum_solution.go b/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/brokenstyle/sum_solution.go new file mode 100644 index 0000000..4c8b56e --- /dev/null +++ b/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/brokenstyle/sum_solution.go @@ -0,0 +1,7 @@ +// +build solution + +package brokenstyle + +func Sum(a, b int64) int64 { + return a + b +} diff --git a/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/brokenstyle/sum_test.go b/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/brokenstyle/sum_test.go new file mode 100644 index 0000000..9ff257c --- /dev/null +++ b/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/brokenstyle/sum_test.go @@ -0,0 +1,22 @@ +package brokenstyle + +import ( + "math" + "testing" +) + +type testCase struct { + a, b, sum int64 +} + +func TestSum(t *testing.T) { + for _, input := range []testCase{ + {a: 2, b: 2, sum: 4}, + {a: 2, b: -2, sum: 0}, + {a: math.MaxInt64, b: 1, sum: math.MinInt64}, + } { + if out := Sum(input.a, input.b); out != input.sum { + t.Errorf("%d + %d == %d != %d", input.a, input.b, out, input.sum) + } + } +} diff --git a/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/brokenstyle/testdata/tests.csv b/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/brokenstyle/testdata/tests.csv new file mode 100644 index 0000000..ed3ada0 --- /dev/null +++ b/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/brokenstyle/testdata/tests.csv @@ -0,0 +1,3 @@ +a,b,sum +0,0,0 +1,-1,0 diff --git a/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/go.mod b/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/go.mod new file mode 100644 index 0000000..395a3ee --- /dev/null +++ b/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/go.mod @@ -0,0 +1,9 @@ +module gitlab.com/slon/shad-go + +go 1.13 + +require ( + github.com/spf13/cobra v0.0.5 + github.com/stretchr/testify v1.4.0 + golang.org/x/tools v0.0.0-20200125223703-d33eef8e6825 +) diff --git a/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/go.sum b/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/go.sum new file mode 100644 index 0000000..9d8b8ff --- /dev/null +++ b/tools/testtool/testdata/submissions/incorrect/brokenstyle/private/go.sum @@ -0,0 +1,53 @@ +github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU= +github.com/armon/consul-api v0.0.0-20180202201655-eb2c6b5be1b6/go.mod h1:grANhF5doyWs3UAsr3K4I6qtAmlQcZDesFNEHPZAzj8= +github.com/coreos/etcd v3.3.10+incompatible/go.mod h1:uF7uidLiAD3TWHmW31ZFd/JWoc32PjwdhPthX9715RE= +github.com/coreos/go-etcd v2.0.0+incompatible/go.mod h1:Jez6KQU2B/sWsbdaef3ED8NzMklzPG4d5KIOhIy30Tk= +github.com/coreos/go-semver v0.2.0/go.mod h1:nnelYz7RCh+5ahJtPPxZlU+153eP4D4r3EedlOD2RNk= +github.com/cpuguy83/go-md2man v1.0.10/go.mod h1:SmD6nW6nTyfqj6ABTjUi3V3JVMnlJmwcJI5acqYI6dE= +github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= +github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c= +github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= +github.com/fsnotify/fsnotify v1.4.7/go.mod h1:jwhsz4b93w/PPRr/qN1Yymfu8t87LnFCMoQvtojpjFo= +github.com/hashicorp/hcl v1.0.0/go.mod h1:E5yfLk+7swimpb2L/Alb/PJmXilQ/rhwaUYs4T20WEQ= +github.com/inconshreveable/mousetrap v1.0.0 h1:Z8tu5sraLXCXIcARxBp/8cbvlwVa7Z1NHg9XEKhtSvM= +github.com/inconshreveable/mousetrap v1.0.0/go.mod h1:PxqpIevigyE2G7u3NXJIT2ANytuPF1OarO4DADm73n8= +github.com/magiconair/properties v1.8.0/go.mod h1:PppfXfuXeibc/6YijjN8zIbojt8czPbwD3XqdrwzmxQ= +github.com/mitchellh/go-homedir v1.1.0/go.mod h1:SfyaCUpYCn1Vlf4IUYiD9fPX4A5wJrkLzIz1N1q0pr0= +github.com/mitchellh/mapstructure v1.1.2/go.mod h1:FVVH3fgwuzCH5S8UJGiWEs2h04kUh9fWfEaFds41c1Y= +github.com/pelletier/go-toml v1.2.0/go.mod h1:5z9KED0ma1S8pY6P1sdut58dfprrGBbd/94hg7ilaic= +github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM= +github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= +github.com/russross/blackfriday v1.5.2/go.mod h1:JO/DiYxRf+HjHt06OyowR9PTA263kcR/rfWxYHBV53g= +github.com/spf13/afero v1.1.2/go.mod h1:j4pytiNVoe2o6bmDsKpLACNPDBIoEAkihy7loJ1B0CQ= +github.com/spf13/cast v1.3.0/go.mod h1:Qx5cxh0v+4UWYiBimWS+eyWzqEqokIECu5etghLkUJE= +github.com/spf13/cobra v0.0.5 h1:f0B+LkLX6DtmRH1isoNA9VTtNUK9K8xYd28JNNfOv/s= +github.com/spf13/cobra v0.0.5/go.mod h1:3K3wKZymM7VvHMDS9+Akkh4K60UwM26emMESw8tLCHU= +github.com/spf13/jwalterweatherman v1.0.0/go.mod h1:cQK4TGJAtQXfYWX+Ddv3mKDzgVb68N+wFjFa4jdeBTo= +github.com/spf13/pflag v1.0.3 h1:zPAT6CGy6wXeQ7NtTnaTerfKOsV6V6F8agHXFiazDkg= +github.com/spf13/pflag v1.0.3/go.mod h1:DYY7MBk1bdzusC3SYhjObp+wFpr4gzcvqqNjLnInEg4= +github.com/spf13/viper v1.3.2/go.mod h1:ZiWeW+zYFKm7srdB9IoDzzZXaJaI5eL9QjNiN/DMA2s= +github.com/stretchr/objx v0.1.0 h1:4G4v2dO3VZwixGIRoQ5Lfboy6nUhCyYzaqnIAPPhYs4= +github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME= +github.com/stretchr/testify v1.2.2/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs= +github.com/stretchr/testify v1.4.0 h1:2E4SXV/wtOkTonXsotYi4li6zVWxYlZuYNCXe9XRJyk= +github.com/stretchr/testify v1.4.0/go.mod h1:j7eGeouHqKxXV5pUuKE4zz7dFj8WfuZ+81PSLYec5m4= +github.com/ugorji/go/codec v0.0.0-20181204163529-d75b2dcb6bc8/go.mod h1:VFNgLljTbGfSG7qAOspJ7OScBnGdDN/yBr0sguwnwf0= +github.com/xordataexchange/crypt v0.0.3-0.20170626215501-b2862e3d0a77/go.mod h1:aYKd//L2LvnjZzWKhF00oedf4jCCReLcmhLdhm1A27Q= +golang.org/x/crypto v0.0.0-20181203042331-505ab145d0a9/go.mod h1:6SG95UA2DQfeDnfUPMdvaQW0Q7yPrPDi9nlGo2tz2b4= +golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w= +golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI= +golang.org/x/mod v0.1.1-0.20191105210325-c90efee705ee/go.mod h1:QqPTAvyqsEbceGzBzNggFXnrqF1CaUcvgkdR5Ot7KZg= +golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg= +golang.org/x/net v0.0.0-20190620200207-3b0461eec859/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s= +golang.org/x/sync v0.0.0-20190423024810-112230192c58 h1:8gQV6CLnAEikrhgkHFbMAEhagSSnXWGV915qUMm9mrU= +golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= +golang.org/x/sys v0.0.0-20181205085412-a5c9d58dba9a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= +golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= +golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= +golang.org/x/tools v0.0.0-20200125223703-d33eef8e6825 h1:aNQeSIHKi0RWpKA5NO0CqyLjx6Beh5l0LLUEnndEjz0= +golang.org/x/tools v0.0.0-20200125223703-d33eef8e6825/go.mod h1:TB2adYChydJhpapKDTa4BR/hXlZSLoq2Wpct/0txZ28= +golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0= +gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= +gopkg.in/yaml.v2 v2.2.2 h1:ZCJp+EgiOT7lHqUV2J862kp8Qj64Jo6az82+3Td9dZw= +gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI= diff --git a/tools/testtool/testdata/submissions/incorrect/brokenstyle/student/brokenstyle/sum.go b/tools/testtool/testdata/submissions/incorrect/brokenstyle/student/brokenstyle/sum.go new file mode 100644 index 0000000..14a8246 --- /dev/null +++ b/tools/testtool/testdata/submissions/incorrect/brokenstyle/student/brokenstyle/sum.go @@ -0,0 +1,8 @@ +// +build !solution + +package brokenstyle + +func Sum(a, b int64) int64 { + a_plus_b := a + b + return a_plus_b +} diff --git a/tools/testtool/testdata/submissions/incorrect/brokenstyle/student/brokenstyle/sum_test.go b/tools/testtool/testdata/submissions/incorrect/brokenstyle/student/brokenstyle/sum_test.go new file mode 100644 index 0000000..1e77eb1 --- /dev/null +++ b/tools/testtool/testdata/submissions/incorrect/brokenstyle/student/brokenstyle/sum_test.go @@ -0,0 +1,23 @@ +package brokenstyle + +import ( + "math" + "testing" +) + +type testCase struct { + a, b, sum int64 +} + +func TestSum(t *testing.T) { + for _, input := range []testCase{ + {a: 2, b: 2, sum: 4}, + {a: 2, b: -2, sum: 0}, + {a: math.MaxInt64, b: 1, sum: math.MinInt64}, + {a: -1, b: -1, sum: -2}, + } { + if out := Sum(input.a, input.b); out != input.sum { + t.Errorf("%d + %d == %d != %d", input.a, input.b, out, input.sum) + } + } +} diff --git a/tools/testtool/testdata/submissions/incorrect/brokenstyle/student/brokenstyle/testdata/tests.csv b/tools/testtool/testdata/submissions/incorrect/brokenstyle/student/brokenstyle/testdata/tests.csv new file mode 100644 index 0000000..ed3ada0 --- /dev/null +++ b/tools/testtool/testdata/submissions/incorrect/brokenstyle/student/brokenstyle/testdata/tests.csv @@ -0,0 +1,3 @@ +a,b,sum +0,0,0 +1,-1,0 diff --git a/tools/testtool/testdata/submissions/incorrect/brokenstyle/student/go.mod b/tools/testtool/testdata/submissions/incorrect/brokenstyle/student/go.mod new file mode 100644 index 0000000..395a3ee --- /dev/null +++ b/tools/testtool/testdata/submissions/incorrect/brokenstyle/student/go.mod @@ -0,0 +1,9 @@ +module gitlab.com/slon/shad-go + +go 1.13 + +require ( + github.com/spf13/cobra v0.0.5 + github.com/stretchr/testify v1.4.0 + golang.org/x/tools v0.0.0-20200125223703-d33eef8e6825 +) diff --git a/tools/testtool/testdata/submissions/incorrect/brokenstyle/student/go.sum b/tools/testtool/testdata/submissions/incorrect/brokenstyle/student/go.sum new file mode 100644 index 0000000..9d8b8ff --- /dev/null +++ b/tools/testtool/testdata/submissions/incorrect/brokenstyle/student/go.sum @@ -0,0 +1,53 @@ +github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU= +github.com/armon/consul-api v0.0.0-20180202201655-eb2c6b5be1b6/go.mod h1:grANhF5doyWs3UAsr3K4I6qtAmlQcZDesFNEHPZAzj8= +github.com/coreos/etcd v3.3.10+incompatible/go.mod h1:uF7uidLiAD3TWHmW31ZFd/JWoc32PjwdhPthX9715RE= +github.com/coreos/go-etcd v2.0.0+incompatible/go.mod h1:Jez6KQU2B/sWsbdaef3ED8NzMklzPG4d5KIOhIy30Tk= +github.com/coreos/go-semver v0.2.0/go.mod h1:nnelYz7RCh+5ahJtPPxZlU+153eP4D4r3EedlOD2RNk= +github.com/cpuguy83/go-md2man v1.0.10/go.mod h1:SmD6nW6nTyfqj6ABTjUi3V3JVMnlJmwcJI5acqYI6dE= +github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= +github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c= +github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= +github.com/fsnotify/fsnotify v1.4.7/go.mod h1:jwhsz4b93w/PPRr/qN1Yymfu8t87LnFCMoQvtojpjFo= +github.com/hashicorp/hcl v1.0.0/go.mod h1:E5yfLk+7swimpb2L/Alb/PJmXilQ/rhwaUYs4T20WEQ= +github.com/inconshreveable/mousetrap v1.0.0 h1:Z8tu5sraLXCXIcARxBp/8cbvlwVa7Z1NHg9XEKhtSvM= +github.com/inconshreveable/mousetrap v1.0.0/go.mod h1:PxqpIevigyE2G7u3NXJIT2ANytuPF1OarO4DADm73n8= +github.com/magiconair/properties v1.8.0/go.mod h1:PppfXfuXeibc/6YijjN8zIbojt8czPbwD3XqdrwzmxQ= +github.com/mitchellh/go-homedir v1.1.0/go.mod h1:SfyaCUpYCn1Vlf4IUYiD9fPX4A5wJrkLzIz1N1q0pr0= +github.com/mitchellh/mapstructure v1.1.2/go.mod h1:FVVH3fgwuzCH5S8UJGiWEs2h04kUh9fWfEaFds41c1Y= +github.com/pelletier/go-toml v1.2.0/go.mod h1:5z9KED0ma1S8pY6P1sdut58dfprrGBbd/94hg7ilaic= +github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM= +github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= +github.com/russross/blackfriday v1.5.2/go.mod h1:JO/DiYxRf+HjHt06OyowR9PTA263kcR/rfWxYHBV53g= +github.com/spf13/afero v1.1.2/go.mod h1:j4pytiNVoe2o6bmDsKpLACNPDBIoEAkihy7loJ1B0CQ= +github.com/spf13/cast v1.3.0/go.mod h1:Qx5cxh0v+4UWYiBimWS+eyWzqEqokIECu5etghLkUJE= +github.com/spf13/cobra v0.0.5 h1:f0B+LkLX6DtmRH1isoNA9VTtNUK9K8xYd28JNNfOv/s= +github.com/spf13/cobra v0.0.5/go.mod h1:3K3wKZymM7VvHMDS9+Akkh4K60UwM26emMESw8tLCHU= +github.com/spf13/jwalterweatherman v1.0.0/go.mod h1:cQK4TGJAtQXfYWX+Ddv3mKDzgVb68N+wFjFa4jdeBTo= +github.com/spf13/pflag v1.0.3 h1:zPAT6CGy6wXeQ7NtTnaTerfKOsV6V6F8agHXFiazDkg= +github.com/spf13/pflag v1.0.3/go.mod h1:DYY7MBk1bdzusC3SYhjObp+wFpr4gzcvqqNjLnInEg4= +github.com/spf13/viper v1.3.2/go.mod h1:ZiWeW+zYFKm7srdB9IoDzzZXaJaI5eL9QjNiN/DMA2s= +github.com/stretchr/objx v0.1.0 h1:4G4v2dO3VZwixGIRoQ5Lfboy6nUhCyYzaqnIAPPhYs4= +github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME= +github.com/stretchr/testify v1.2.2/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs= +github.com/stretchr/testify v1.4.0 h1:2E4SXV/wtOkTonXsotYi4li6zVWxYlZuYNCXe9XRJyk= +github.com/stretchr/testify v1.4.0/go.mod h1:j7eGeouHqKxXV5pUuKE4zz7dFj8WfuZ+81PSLYec5m4= +github.com/ugorji/go/codec v0.0.0-20181204163529-d75b2dcb6bc8/go.mod h1:VFNgLljTbGfSG7qAOspJ7OScBnGdDN/yBr0sguwnwf0= +github.com/xordataexchange/crypt v0.0.3-0.20170626215501-b2862e3d0a77/go.mod h1:aYKd//L2LvnjZzWKhF00oedf4jCCReLcmhLdhm1A27Q= +golang.org/x/crypto v0.0.0-20181203042331-505ab145d0a9/go.mod h1:6SG95UA2DQfeDnfUPMdvaQW0Q7yPrPDi9nlGo2tz2b4= +golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w= +golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI= +golang.org/x/mod v0.1.1-0.20191105210325-c90efee705ee/go.mod h1:QqPTAvyqsEbceGzBzNggFXnrqF1CaUcvgkdR5Ot7KZg= +golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg= +golang.org/x/net v0.0.0-20190620200207-3b0461eec859/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s= +golang.org/x/sync v0.0.0-20190423024810-112230192c58 h1:8gQV6CLnAEikrhgkHFbMAEhagSSnXWGV915qUMm9mrU= +golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= +golang.org/x/sys v0.0.0-20181205085412-a5c9d58dba9a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= +golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= +golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= +golang.org/x/tools v0.0.0-20200125223703-d33eef8e6825 h1:aNQeSIHKi0RWpKA5NO0CqyLjx6Beh5l0LLUEnndEjz0= +golang.org/x/tools v0.0.0-20200125223703-d33eef8e6825/go.mod h1:TB2adYChydJhpapKDTa4BR/hXlZSLoq2Wpct/0txZ28= +golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0= +gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= +gopkg.in/yaml.v2 v2.2.2 h1:ZCJp+EgiOT7lHqUV2J862kp8Qj64Jo6az82+3Td9dZw= +gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI= diff --git a/tools/testtool/testdata/submissions/incorrect/brokentest/private/.golangci.yml b/tools/testtool/testdata/submissions/incorrect/brokentest/private/.golangci.yml new file mode 100644 index 0000000..4b4d4be --- /dev/null +++ b/tools/testtool/testdata/submissions/incorrect/brokentest/private/.golangci.yml @@ -0,0 +1,77 @@ +# options for analysis running +run: + # default concurrency is a available CPU number + concurrency: 8 + + # timeout for analysis, e.g. 30s, 5m, default is 1m + deadline: 5m + + # exit code when at least one issue was found, default is 1 + issues-exit-code: 1 + + # include test files or not, default is true + tests: true + + +# output configuration options +output: + # colored-line-number|line-number|json|tab|checkstyle, default is "colored-line-number" + format: colored-line-number + + # print lines of code with issue, default is true + print-issued-lines: true + + # print linter name in the end of issue text, default is true + print-linter-name: true + + +# all available settings of specific linters +linters-settings: + govet: + # report about shadowed variables + check-shadowing: true + golint: + # minimal confidence for issues, default is 0.8 + min-confidence: 0.8 + gofmt: + # simplify code: gofmt with `-s` option, true by default + simplify: true + goimports: + # put imports beginning with prefix after 3rd-party packages; + # it's a comma-separated list of prefixes + local-prefixes: gitlab.com + +linters: + disable-all: true + enable: + - errcheck + - gofmt + - golint + - gosimple + - govet + - ineffassign + - scopelint + - staticcheck + - typecheck + - unconvert + + +issues: + # List of regexps of issue texts to exclude, empty list by default. + # But independently from this option we use default exclude patterns, + # it can be disabled by `exclude-use-default: false`. To list all + # excluded by default patterns execute `golangci-lint run --help` + exclude: + - Using the variable on range scope .* in function literal + + # Independently from option `exclude` we use default exclude patterns, + # it can be disabled by this option. To list all + # excluded by default patterns execute `golangci-lint run --help`. + # Default value for this option is true. + exclude-use-default: true + + # Maximum issues count per one linter. Set to 0 to disable. Default is 50. + max-per-linter: 0 + + # Maximum count of issues with the same text. Set to 0 to disable. Default is 3. + max-same-issues: 0 diff --git a/tools/testtool/testdata/submissions/incorrect/newdependency/private/.golangci.yml b/tools/testtool/testdata/submissions/incorrect/newdependency/private/.golangci.yml new file mode 100644 index 0000000..4b4d4be --- /dev/null +++ b/tools/testtool/testdata/submissions/incorrect/newdependency/private/.golangci.yml @@ -0,0 +1,77 @@ +# options for analysis running +run: + # default concurrency is a available CPU number + concurrency: 8 + + # timeout for analysis, e.g. 30s, 5m, default is 1m + deadline: 5m + + # exit code when at least one issue was found, default is 1 + issues-exit-code: 1 + + # include test files or not, default is true + tests: true + + +# output configuration options +output: + # colored-line-number|line-number|json|tab|checkstyle, default is "colored-line-number" + format: colored-line-number + + # print lines of code with issue, default is true + print-issued-lines: true + + # print linter name in the end of issue text, default is true + print-linter-name: true + + +# all available settings of specific linters +linters-settings: + govet: + # report about shadowed variables + check-shadowing: true + golint: + # minimal confidence for issues, default is 0.8 + min-confidence: 0.8 + gofmt: + # simplify code: gofmt with `-s` option, true by default + simplify: true + goimports: + # put imports beginning with prefix after 3rd-party packages; + # it's a comma-separated list of prefixes + local-prefixes: gitlab.com + +linters: + disable-all: true + enable: + - errcheck + - gofmt + - golint + - gosimple + - govet + - ineffassign + - scopelint + - staticcheck + - typecheck + - unconvert + + +issues: + # List of regexps of issue texts to exclude, empty list by default. + # But independently from this option we use default exclude patterns, + # it can be disabled by `exclude-use-default: false`. To list all + # excluded by default patterns execute `golangci-lint run --help` + exclude: + - Using the variable on range scope .* in function literal + + # Independently from option `exclude` we use default exclude patterns, + # it can be disabled by this option. To list all + # excluded by default patterns execute `golangci-lint run --help`. + # Default value for this option is true. + exclude-use-default: true + + # Maximum issues count per one linter. Set to 0 to disable. Default is 50. + max-per-linter: 0 + + # Maximum count of issues with the same text. Set to 0 to disable. Default is 3. + max-same-issues: 0