erius/shad-go
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

testtool: fix cover profile permissions issue by writing profile to /tmp.

Browse source
This commit is contained in:
Arseny Balobanov 2020-03-20 13:00:17 +03:00
parent a74e207ea3
commit 5f1b033f10
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
tools/testtool/commands/test_submission.go
View file

@ -263,11 +263,12 @@ func runTests(testDir, privateRepo, problem string) error {
for testPkg, testBinary := range testBinaries { for testPkg, testBinary := range testBinaries {
relPath := strings.TrimPrefix(testPkg, moduleImportPath) relPath := strings.TrimPrefix(testPkg, moduleImportPath)
coverProfile := path.Join(os.TempDir(), randomName())
{ {
cmd := exec.Command(testBinary) cmd := exec.Command(testBinary)
if coverageReq.Enabled { if coverageReq.Enabled {
cmd = exec.Command(testBinary, "-test.coverprofile", "c.out") cmd = exec.Command(testBinary, "-test.coverprofile", coverProfile)
} }
if currentUserIsRoot() { if currentUserIsRoot() {
if err := sandbox(cmd); err != nil { if err := sandbox(cmd); err != nil {
@ -288,7 +289,7 @@ func runTests(testDir, privateRepo, problem string) error {
if coverageReq.Enabled { if coverageReq.Enabled {
log.Printf("checking coverage is at least %.2f%% for %s", coverageReq.Percent, testPkg) log.Printf("checking coverage is at least %.2f%% for %s", coverageReq.Percent, testPkg)
percent, err := calCoverage(filepath.Join(testDir, relPath, "c.out")) percent, err := calCoverage(coverProfile)
if err != nil { if err != nil {
return err return err
} }